set self.error in the on_error event handler

[padawin]

I tried once to convert a file on a device having not enough place, with the "delete original files" option checked.
The converted file has not been created because of the missing place, but the original file has been deleted.

I set self.error in Converter.on_error, so the test "if self.delete_original and self.processing and not self.error:" properly fails in Converter.finished.

Please let me know if it is the good way to achieve this.

[mschwendt]

Sounds plausible, since the same fix is present in all the other on_error handlers in gstreamer.py (including the Decoder class which Converter is based on).

[kassoulet]

This is definitely wrong. Good catch!
I can't see why on_error() is redefined in Decoder and Converter, so I will remove them and keep only an error handler in Pipeline, where it make sense.

[kassoulet]

I'm using this fix for master, the on_error() merge will be live in the py3k branch.

[padawin]

ok great.