Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set self.error in the on_error event handler #8

Merged
merged 1 commit into from Jan 3, 2014

Conversation

padawin
Copy link

@padawin padawin commented Dec 31, 2013

I tried once to convert a file on a device having not enough place, with the "delete original files" option checked.
The converted file has not been created because of the missing place, but the original file has been deleted.

I set self.error in Converter.on_error, so the test "if self.delete_original and self.processing and not self.error:" properly fails in Converter.finished.

Please let me know if it is the good way to achieve this.

@mschwendt
Copy link

Sounds plausible, since the same fix is present in all the other on_error handlers in gstreamer.py (including the Decoder class which Converter is based on).

@kassoulet
Copy link
Owner

This is definitely wrong. Good catch!
I can't see why on_error() is redefined in Decoder and Converter, so I will remove them and keep only an error handler in Pipeline, where it make sense.

kassoulet added a commit that referenced this pull request Jan 3, 2014
set self.error in the on_error event handler
@kassoulet kassoulet merged commit 0c6685a into kassoulet:master Jan 3, 2014
@kassoulet
Copy link
Owner

I'm using this fix for master, the on_error() merge will be live in the py3k branch.

@padawin
Copy link
Author

padawin commented Jan 3, 2014

ok great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants