set self.error in the on_error event handler #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried once to convert a file on a device having not enough place, with the "delete original files" option checked.
The converted file has not been created because of the missing place, but the original file has been deleted.
I set self.error in Converter.on_error, so the test "if self.delete_original and self.processing and not self.error:" properly fails in Converter.finished.
Please let me know if it is the good way to achieve this.